Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Bound<'py, PyStr> str equality #166

Merged
merged 2 commits into from
Nov 19, 2024
Merged

use Bound<'py, PyStr> str equality #166

merged 2 commits into from
Nov 19, 2024

Conversation

davidhewitt
Copy link
Collaborator

@davidhewitt davidhewitt commented Nov 19, 2024

PyO3 implements direct Python to Rust str equality, which should be the most efficient pathway on any given platform.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (8ae5b41) to head (9f04707).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   88.90%   88.92%   +0.02%     
==========================================
  Files          13       13              
  Lines        2191     2195       +4     
  Branches     2191     2195       +4     
==========================================
+ Hits         1948     1952       +4     
  Misses        148      148              
  Partials       95       95              
Files with missing lines Coverage Δ
crates/jiter/src/py_string_cache.rs 97.16% <100.00%> (+0.11%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ae5b41...9f04707. Read the comment docs.

---- 🚨 Try these New Features:

Copy link

codspeed-hq bot commented Nov 19, 2024

CodSpeed Performance Report

Merging #166 will improve performances by 12.37%

Comparing dh/py-str-eq (9f04707) with main (8ae5b41)

Summary

⚡ 1 improvements
✅ 72 untouched benchmarks

Benchmarks breakdown

Benchmark main dh/py-str-eq Change
python_parse_string_array 26.6 µs 23.7 µs +12.37%

@davidhewitt davidhewitt merged commit f970f0b into main Nov 19, 2024
23 checks passed
@davidhewitt davidhewitt deleted the dh/py-str-eq branch November 19, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant