Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to PyO3 0.23 #137

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Upgrade to PyO3 0.23 #137

merged 4 commits into from
Nov 15, 2024

Conversation

davidhewitt
Copy link
Collaborator

PyO3 0.23 contains some breaking changes & perf changes, want to check these briefly against jiter & core...

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 32 lines in your changes missing coverage. Please review.

Project coverage is 88.90%. Comparing base (1fbdb1e) to head (53622f1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/jiter/src/value.rs 41.17% 13 Missing and 7 partials ⚠️
crates/jiter/src/python.rs 61.53% 3 Missing and 7 partials ⚠️
crates/jiter/src/number_decoder.rs 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
- Coverage   91.09%   88.90%   -2.19%     
==========================================
  Files          13       13              
  Lines        2145     2191      +46     
  Branches     2145     2191      +46     
==========================================
- Hits         1954     1948       -6     
- Misses        109      148      +39     
- Partials       82       95      +13     
Files with missing lines Coverage Δ
crates/jiter/src/py_lossless_float.rs 84.90% <100.00%> (+1.26%) ⬆️
crates/jiter/src/py_string_cache.rs 97.05% <100.00%> (ø)
crates/jiter/src/number_decoder.rs 88.73% <0.00%> (-2.76%) ⬇️
crates/jiter/src/python.rs 90.86% <61.53%> (-3.17%) ⬇️
crates/jiter/src/value.rs 81.10% <41.17%> (-7.00%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fbdb1e...53622f1. Read the comment docs.

Copy link

codspeed-hq bot commented Sep 13, 2024

CodSpeed Performance Report

Merging #137 will improve performances by 10.24%

Comparing dh/pyo3-0.23 (53622f1) with main (1fbdb1e)

Summary

⚡ 1 improvements
✅ 72 untouched benchmarks

Benchmarks breakdown

Benchmark main dh/pyo3-0.23 Change
unicode_jiter_value 9.5 µs 8.6 µs +10.24%

@davidhewitt davidhewitt changed the title wip test PyO3 HEAD Upgrade to PyO3 0.23 Nov 15, 2024
@davidhewitt davidhewitt marked this pull request as ready for review November 15, 2024 19:16
@davidhewitt davidhewitt merged commit 9bde9e1 into main Nov 15, 2024
22 of 23 checks passed
@davidhewitt davidhewitt deleted the dh/pyo3-0.23 branch November 15, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant