Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraalPy support #135

Merged
merged 1 commit into from
Sep 17, 2024
Merged

GraalPy support #135

merged 1 commit into from
Sep 17, 2024

Conversation

steve-s
Copy link
Contributor

@steve-s steve-s commented Sep 11, 2024

This makes jiter work on GraalPy except for test_python_parse_numeric, for which GraalPy will need to provide missing API _PyLong_FromByteArray.

Update: the API is now implemented in GraalPy main branch.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.55%. Comparing base (754395c) to head (3cc2e62).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   94.55%   94.55%           
=======================================
  Files          12       12           
  Lines        2039     2039           
=======================================
  Hits         1928     1928           
  Misses        111      111           
Files with missing lines Coverage Δ
crates/jiter/src/py_string_cache.rs 97.05% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 754395c...3cc2e62. Read the comment docs.

Copy link

codspeed-hq bot commented Sep 11, 2024

CodSpeed Performance Report

Merging #135 will not alter performance

Comparing steve-s:graalpy (3cc2e62) with main (754395c)

Summary

✅ 73 untouched benchmarks

@samuelcolvin samuelcolvin merged commit 20b950f into pydantic:main Sep 17, 2024
24 checks passed
@samuelcolvin
Copy link
Member

thank so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants