-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make num-bigint optional #130
Conversation
CodSpeed Performance ReportMerging #130 will improve performances by 10.75%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
=======================================
Coverage 94.91% 94.91%
=======================================
Files 12 12
Lines 1908 1909 +1
=======================================
+ Hits 1811 1812 +1
Misses 97 97
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks so much.
@davidhewitt you happy with this?
I tried to merge with main to fix the fuzz failures, but you've blocked contributions from maintainers, @fasterthanlime could you rebase please?
c95419b
to
c611089
Compare
Done! |
(Is there a way to "Allow edits by maintainers" after the fact?) |
Thanks so much.
I think there might be a way, perhaps a checkbox once if you edit the PR body? Anyway, happy to merge this once @davidhewitt has a quick check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super, thanks very much!
Thanks for the review+merge! Can you tag me when this lands on crates.io? (By the way I recommend the excellent release-plz for release automation, in case you're interested) |
I've raised a followup PR for this one as it looks like |
Closes #124
Apologies for the few TOML reformats that slipped through, I can get rid of those if needed.
A few statics got turned into consts and moved inline with the BigInt code to avoid "unused variable" warnings.
I would recommend running
cargo hack --feature-powerset check
in CI, from https://lib.rs/crates/cargo-hackA "default features build" (with num-bigint) is 4.7s at best for me:
Command used:
And a "no default features" build is just under two seconds:
Command used: