🐛 Make file processing with ClassDefVisitor deterministic
#118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using `set` for specifying files in queue we loose the order in which the files will be processed (in `missing_files` var).
So we process the queue left to right. This way the `appendleft` call makes sense and we process the same file as first one as with the previous implementation.
Turns out `.glob(...)` yields results in "arbitrary order", so the file list for processing might be in different order on different OSes. See docs for `os.scandir` (the thing `glob` uses under the hood): https://docs.python.org/3/library/os.html?highlight=arbitrary%20order#os.scandir
slafs
changed the title
Kludex
approved these changes
Aug 14, 2023
|
Thanks @slafs ❤️ |
Kludex
changed the title
ClassDefVisitor deterministic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #117 (non-determinism part)
queuecreation and element addition while processing