Update calls to numpy.reshape to avoid deprecation warnings
#433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
campospinto
reviewed
Sep 17, 2024
|
Yes exactly, I was a little too fast with the changes, but I don't know if there is any actual benefit of maintaining old versions of Python for long times (especially since all newer NumPy versions will not be compatible). But we could also remove the keywords in |
yguclu
changed the title
np.reshape to avoid deprecation warnings
yguclu
approved these changes
Sep 18, 2024
yguclu
changed the title
np.reshape to avoid deprecation warningsnumpy.reshape to avoid deprecation warnings
max-models
pushed a commit
that referenced
this pull request
Oct 1, 2024
NumPy 2.1 deprecates the `newshape` argument of the `reshape` function. Instead, one should use the positional-only argument `shape`. Every call in Psydac has been updated accordingly. This closes #432.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NumPy 2.1 deprecates the
newshapeargument of thereshapefunction. Instead, one should use the positional-only argumentshape. Every call in Psydac has been updated accordingly. This closes #432.