Add support for cryptography
CRLs to X509Store
#1252
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up to deprecating CRL APIs (#1249), there is one remaining function that won't be deprecated but accepts the
CRL
type:X509Store.add_crl(crl: CRL)
. In order to give users an alternative onceCRL
is deprecated, this PR adds support toadd_crl()
so that it also acceptscryptography
'sX509.CertificateRevocationList
.This PR also adds tests for the new code path, by parametrizing existing tests that use
add_crl
so that the CRL being passed as a parameter is either PyOpenSSL's or cryptography's. For example: