Reduce MD5 and SHA1 dependency in tests #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the tests aren't specifically testing MD5 or SHA1. Switch those to a modern hash.
reaperhulk
reviewed
Jan 10, 2022
reaperhulk
reviewed
Jan 10, 2022
alex
reviewed
Jan 10, 2022
| @@ -64,7 +64,7 @@ def normalize_privatekey_pem(pem): | |||
| GOOD_CIPHER = "blowfish" | |||
| BAD_CIPHER = "zippers" | |||
|
|
|||
| GOOD_DIGEST = "SHA1" | |||
reaperhulk
approved these changes
Jan 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the tests aren't specifically testing MD5 or SHA1. Switch those to a modern hash.