Accept pathlib.Path as a valid path #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello? Plz? |
|
I think this would be more appropriately handled with |
|
Done |
alex
reviewed
Dec 19, 2021
src/OpenSSL/_util.py
Outdated
| return s.encode(sys.getfilesystemencoding()) | ||
| try: | ||
| strpath = os.fspath(s) | ||
| except Exception: |
There was a problem hiding this comment.
Why do we need to catch exceptions here? What case is that handling?
There was a problem hiding this comment.
In [2]: os.fspath(1)
---------------------------------------------------------------------------
TypeError Traceback (most recent call last)
<ipython-input-2-b00c080840d9> in <module>
----> 1 os.fspath(1)
TypeError: expected str, bytes or os.PathLike object, not int
There was a problem hiding this comment.
Just because you seem to want to provide your own message. I'd be fine to not handle it and remove the else case later on as well.
There was a problem hiding this comment.
Yes, I think allowing the exception from os.fspath to propagate is fine.
And also whatever supports the protocol. Way more pythonic now!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also whatever can be converted to bytes.
Way more pythonic now!