Create py.typed

[graingert]

the changelog lists:

cryptography now has PEP 484 type hints on nearly all of of its public APIs. Users can begin using them to type check their code with mypy.

but I'm still falling back to typeshed because this file is missing

[tiran]

You also need to add the file to package data, https://www.python.org/dev/peps/pep-0561/#packaging-type-information

[graingert]

You also need to add the file to package data, https://www.python.org/dev/peps/pep-0561/#packaging-type-information

Isn't it already covered with include_package_data ?

[tiran]

You also need to add the file to package data, python.org/dev/peps/pep-0561/#packaging-type-information

Isn't it already covered with include_package_data ?

Is include_package_data=True sufficient? I honestly don't know! Could you please check sdist and wheels?

[tiran]

You definitely have to add it to MANIFEST.in:

flake run-test: commands[2] | check-manifest
lists of files in version control and sdist do not match!
missing from sdist:
  src/cryptography/py.typed
suggested MANIFEST.in rules:
  recursive-include src *.typed

[tiran]

Does the file have to empty? In the past some zip tools had issues with 0 byte files.

[graingert]

Suggested change

I intended for this file to be 0 bytes

[alex]

Yes, let's make this a proper 0-byte file (that's what we use on pyca/bcrypt)

[tiran]

You also need to add the file to package data, python.org/dev/peps/pep-0561/#packaging-type-information

Isn't it already covered with include_package_data ?

Is include_package_data=True sufficient? I honestly don't know! Could you please check sdist and wheels?

Yes, it's sufficient.

$ python3 setup.py bdist_wheel
$ unzip -l dist/cryptography-3.5.dev1-cp39-cp39-linux_x86_64.whl | grep py.typed
        0  02-09-2021 12:36   cryptography/py.typed

[intgr]

So should cryptography stubs be removed entirely from typeshed repo?

[alex]

I don't know how typeshed handles multiple versions of packages, but with respect to 3.4, yes.

…

On Thu, Feb 11, 2021 at 5:57 AM Marti Raudsepp ***@***.***> wrote: So should cryptography stubs be removed entirely from typeshed repo? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

-- All that is necessary for evil to succeed is for good people to do nothing.