Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin the deprecation of auto-idna for x509.DNSName #3830

Merged
merged 12 commits into from
Jul 30, 2017

Conversation

alex
Copy link
Member

@alex alex commented Jul 29, 2017

Refs #3357

@mention-bot
Copy link

@alex, thanks for your PR! By analyzing the history of the files in this pull request, we identified @reaperhulk, @sigmavirus24 and @frasertweedale to be potential reviewers.

@alex alex added this to the Twenty first release milestone Jul 29, 2017
Copy link
Member

@reaperhulk reaperhulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment/question

@@ -2220,16 +2275,20 @@ def test_other_name(self, backend):
assert othernames == [expected]

def test_certbuilder(self, backend):
sans = [u'*.example.org', u'*.\xf5\xe4\xf6\xfc.example.com',
u'foobar.example.net']
sans = [b'*.example.org', b'*.\xf5\xe4\xf6\xfc.example.com',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be b'*.xn--4ca7aey.example.com' or just be removed from the SAN list? Previously this tested that it was encoding idna properly, but now they're all just bytes being passed along (and we're passing non-ascii bytes here, so we're sort of testing whether OpenSSL will tolerate such garbage)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@reaperhulk reaperhulk merged commit cdaf3ff into pyca:master Jul 30, 2017
@alex alex deleted the idna-was-mistake branch July 30, 2017 17:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants