Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelog and version bump for 2.0.2 #3826

Merged
merged 2 commits into from
Jul 27, 2017
Merged

Conversation

reaperhulk
Copy link
Member

This obviously should be merged after the backport for #3825

@mention-bot
Copy link

@reaperhulk, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alex, @Ivoz and @palaviv to be potential reviewers.

@@ -1,6 +1,12 @@
Changelog
=========

2.0.2 - 2017-07-27
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's the 27th somewhere...

CHANGELOG.rst Outdated
~~~~~~~~~~~~~~~~~~

* Marked all symbols as hidden in the ``manylinux1`` wheel to avoid a
bug with symbol resolution in older Linux distributions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug isn't with older Linux distributions, it just happens to materialize with a python shipped by an older distro.

I don't know what the right thing to write here is.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Symbol resolution in certain scenarios" 😛

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds fine :D

@srikalyan
Copy link

When is this going to be released? 2.0.1 is causing segfaults on ubuntu 14.04 :(

@reaperhulk
Copy link
Member Author

@srikalyan very shortly. We haven't been able to reproduce this on 14.04 with system Python, but we were able to reproduce on 12.04 and confirm this fixes it.

@srikalyan
Copy link

I can confirm that this is broken on 14.04.5 (fresh system). I will let you know if the fix works on the 14.04.5

@alex alex merged commit 38a2d0b into pyca:2.0.x Jul 27, 2017
@reaperhulk
Copy link
Member Author

@srikalyan if you can replicate it right now would you mind trying https://f001.backblazeb2.com/file/dropshare-fenrir/cryptography-2.0.1-cp27-cp27mu-linux_x86_64.whl (that's a 2.0.1 wheel built with the fix). I'd like to confirm this works before releasing 2.0.2

@reaperhulk reaperhulk deleted the 2.0.2-changelog branch July 27, 2017 03:11
@srikalyan
Copy link

Sure give me like an hour?

@reaperhulk
Copy link
Member Author

I started the 2.0.2 release process already so it'll be up shortly. If 2.0.2 doesn't resolve it please file a new issue with a full reproducer so we can figure out the next level of this rabbit hole 😄

@srikalyan
Copy link

I have already got 2.0.2 :) and it seems to fix the problem. Thank you everyone.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants