add AESGCM AEAD support #3785
Merged
add AESGCM AEAD support #3785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is unfortunately going to add about 20-30s to each test run and some indeterminate amount of RAM consumed |
alex
reviewed
Jul 16, 2017
docs/hazmat/primitives/aead.rst
Outdated
| @@ -161,3 +161,74 @@ also support providing integrity for associated data which is not encrypted. | |||
| doesn't validate this exception will be raised. This will occur | |||
| when the ciphertext has been changed, but will also occur when the | |||
| key, nonce, or associated data are wrong. | |||
|
|
|||
| .. class:: AESGCM(key) | |||
|
This also fixes #1199 |
alex
approved these changes
Jul 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3784
I decided to name it
noncethis time. This makes us inconsistent with the arg naming on theGCMmode itself, but I think we should call it anoncesince that's what it is. NIST's own GCM document calls it an initialization vector but then ALSO says it is synonymous with nonce.