remove egd #3771
Merged
remove egd #3771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reaperhulk, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alex, @Ayrx and @palaviv to be potential reviewers. |
alex
reviewed
Jul 9, 2017
| @@ -75,14 +75,6 @@ def cryptography_has_rsa_r_pkcs_decoding_error(): | |||
| ] | |||
|
|
|||
|
|
|||
| def cryptography_has_egd(): | |||
alex
reviewed
Jul 9, 2017
src/_cffi_src/openssl/rand.py
Outdated
| @@ -9,7 +9,6 @@ | |||
| """ | |||
|
|
|||
| TYPES = """ | |||
| static const long Cryptography_HAS_EGD; | |||
There was a problem hiding this comment.
Should we leave this constant but set to 0? Then there's no plausible backwards compat concern :-)
There was a problem hiding this comment.
Sure, why not. At some point it'd be good to remove it entirely but the two lines aren't going to be a maintenance burden in any way...
This shouldn't really be necessary but maybe we can fully remove it in 2018 or 2019...
alex
approved these changes
Jul 9, 2017
|
Landing despite the coverage because it appears to be a bug. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EGD is bad and old and we removed it from pyOpenSSL in 16.0.