Merge pull request #2594 from reaperhulk/hash-bc

implement hash on basicconstraints
pyca · Dec 27, 2015 · b25888d · b25888d
2 parents b04b67e + b39af8d
commit b25888d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/cryptography/x509/extensions.py b/src/cryptography/x509/extensions.py
@@ -342,6 +342,9 @@ def __eq__(self, other):
     def __ne__(self, other):
         return not self == other
 
+    def __hash__(self):
+        return hash((self.ca, self.path_length))
+
 
 @utils.register_interface(ExtensionType)
 class CRLDistributionPoints(object):

diff --git a/tests/test_x509_ext.py b/tests/test_x509_ext.py
@@ -837,6 +837,13 @@ def test_repr(self):
             "<BasicConstraints(ca=True, path_length=None)>"
         )
 
+    def test_hash(self):
+        na = x509.BasicConstraints(ca=True, path_length=None)
+        na2 = x509.BasicConstraints(ca=True, path_length=None)
+        na3 = x509.BasicConstraints(ca=True, path_length=0)
+        assert hash(na) == hash(na2)
+        assert hash(na) != hash(na3)
+
     def test_eq(self):
         na = x509.BasicConstraints(ca=True, path_length=None)
         na2 = x509.BasicConstraints(ca=True, path_length=None)