Support the free-threaded build #913
Comments
|
@alex was looking at this and discovered that setup-python doesn't currently have 3.13t, which is a bit unfortunate. |
|
I guess this means we should do a release so that at least it doesn't crash for people. Then we can do follow ups to test it, and set |
|
If you're ok with temporarily switching out We're hoping that github will at least publicly comment on supporting free-threaded python soon. I totally understand as a security-minded project if you'd prefer to stick with the "official" actions workflows. |
|
4.2.1 is now released so we shouldn't crash 😄 I'm not a huge fan of merging a fork of such a core actions dep, although with full hash pinning (assuming the forked action does hash pinning too!) then the risk isn't much. What do you think Alex? |
|
I'm also not a fan, though it's primarily driven from a concern that it's
more likely to become unmaintained and we'll forget.
…On Tue, Nov 19, 2024, 3:19 PM Paul Kehrer ***@***.***> wrote:
4.2.1 is now released so we shouldn't crash 😄
I'm not a huge fan of merging a fork of such a core actions dep, although
with full hash pinning (assuming the forked action does hash pinning too!)
then the risk isn't much. What do you think Alex?
—
Reply to this email directly, view it on GitHub
<#913 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBH5CNKJEWHFH6MHAPL2BOMLVAVCNFSM6AAAAABSC5CKQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBWGY3DQMBYG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
There hasn't been a need to do any releases on our fork yet, but our plan is to keep things in sync with upstream and for dependabot to pick up on releases. I have NumPy set up to use our fork to test free-threading and we use hash pinning and dependabot over there as well. Ping @andfoy who has taken on maintaining the fork. The plan is also to do a final release announcing the end of the fork so people see it in dependabot. We'll contact all the projects we can find using it on public repos with PRs to switch back to setup-python whenever they add support. |
|
Okay, given that commitment (and the diligence you've shown so far, thank you again!) I think I'm fine with saying we can take a temporary dep on that to unblock CI/wheel builders for free threaded wheels. Does your current fork also support linux arm64 3.13t? We have runners that need that. |
|
I don't know if anyone has tried it yet, but as long as the upstream setup-python supports it then it should work. Also PyO3/maturin#2310 needs to be finished and maturin needs to do a release before wheel uploads are possible. |
|
This project still uses setuptools-rust. We ought to switch.
…On Fri, Nov 22, 2024 at 1:18 PM Nathan Goldbaum ***@***.***> wrote:
I don't know if anyone has tried it yet, but as long as the upstream
setup-python supports it then it should work.
Also PyO3/maturin#2310 <PyO3/maturin#2310> needs
to be finished and maturin needs to do a release before wheel uploads are
possible.
—
Reply to this email directly, view it on GitHub
<#913 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBGRTZW6MNWOEL44LID2B5YQ3AVCNFSM6AAAAABSC5CKQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJUGQ3TSMZQG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
All that is necessary for evil to succeed is for good people to do nothing.
|
Currently if you do
pip install bcrypton the free-threaded build, you'll get a completely broken install:Ultimately this is happening because the version of bcrypt on pypi points at PyO3 0.22, which can't support the free-threaded build. It looks like you've already updated to PyO3 0.23 on
main, so the next release should fix the crashes that projects depending on bcrypt will run into.Separately, we should look at adding CI for free-threaded Python 3.13 and look at setting up multithreaded tests.
The text was updated successfully, but these errors were encountered: