Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a way to not use == in the README #8

Closed
alex opened this issue Mar 26, 2014 · 3 comments · Fixed by #86
Closed

Find a way to not use == in the README #8

alex opened this issue Mar 26, 2014 · 3 comments · Fixed by #86

Comments

@alex
Copy link
Member

alex commented Mar 26, 2014

I don't think it's actually exploitable as a timing attack (in fact I'm pretty sure it's not), but I think it'd be good hygeine to offer a check_password function or similar and use that, so we dont' have to expose a general purpose constant time comparison function.

@charmander
Copy link

It’s nice not to expose a general-purpose constant-time comparison function for sure, since it’s not bcrypt’s job to do that, but you’re right that that particular timing attack doesn’t work against bcrypt either; why would it need one in the first place, exposed or not?

@wbolster
Copy link

Fwiw, the standard library provides hmac.compare_digest() since 2.7.x.

@reaperhulk
Copy link
Member

#76 will solve this

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants