-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find a way to not use == in the README #8
Comments
It’s nice not to expose a general-purpose constant-time comparison function for sure, since it’s not bcrypt’s job to do that, but you’re right that that particular timing attack doesn’t work against bcrypt either; why would it need one in the first place, exposed or not? |
Fwiw, the standard library provides |
paragonie-scott
added a commit
to paragonie-scott/bcrypt
that referenced
this issue
Feb 15, 2016
Closed
#76 will solve this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I don't think it's actually exploitable as a timing attack (in fact I'm pretty sure it's not), but I think it'd be good hygeine to offer a check_password function or similar and use that, so we dont' have to expose a general purpose constant time comparison function.
The text was updated successfully, but these errors were encountered: