[Bug] Fix program storage size definitions. #739
Assignees
Labels
bug
Something isn't working
software: pybricks-micropython
Issues with Pybricks MicroPython firmware (or EV3 runtime)
Comments
laurensvalk
added
bug
laurensvalk
added a commit
to pybricks/pybricks-micropython
that referenced
this issue
Oct 20, 2022
Instead of using a getter function to get the size from a linker file (Powered Up) or platform data (SPIKE) , set it as a PBDRV configuration variable. This will allow us to do compile-time checks, and use it to derive the correct values for config values such as PBSYS_APP_USER_PROGRAM_SIZE (this will be done in the next commits). This way have to set only one program size constraint (based on ROM size) and one tuning variable to balance heap/stack, instead of many interdependent settings. See pybricks/support#739
laurensvalk
added a commit
to pybricks/pybricks-micropython
that referenced
this issue
Oct 20, 2022
Ensures the maximum program size can be saved on the hub. Fixes pybricks/support#739
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Since pybricks/pybricks-micropython@2e97a74 and related commits, there are 4 different places where maximum size is defined/constrained and with different values, when it used to be just 1.
This causes situations where you can run programs that can't be saved, etc.
I'll have a look at how it works since the revision to see if we can make it more consistent.
The text was updated successfully, but these errors were encountered: