Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Builds have incorrect version number reported #1136

Closed
laurensvalk opened this issue Jul 3, 2023 · 5 comments
Closed

CI Builds have incorrect version number reported #1136

laurensvalk opened this issue Jul 3, 2023 · 5 comments
Labels
devops Issues related to continuous integration and distribution of software.

Comments

@laurensvalk
Copy link
Member 

          > What are you seeing on this screen?

image

image

Did another try and got this version:
('technichub', '3.3.0b7', 'v1.20.0-23-g6c633a8dd on 2023-07-03')

Originally posted by @BertLindeman in #1131 (comment)
@laurensvalk laurensvalk added the devops Issues related to continuous integration and distribution of software. label Jul 3, 2023
@laurensvalk
Copy link
Member Author

laurensvalk commented Jul 3, 2023 •
edited
Loading

I can confirm, I also got v1.20.0-23-g6c633a8dd on 2023-07-03 from technichub-firmware-build-2956-gitef4ae702.zip.

Same for Prime Hub.

@dlech dlech changed the title [Bug] Possible nightly link caching issue CI Builds with multiple new commits are uploading artifacts using the oldest commit instead of the newest commit Jul 3, 2023
@dlech
Copy link
Member

dlech commented Jul 3, 2023

This is probably related to recent changes to the build-each-commit.py script. I remember having to mess with the order that commits were built in to fix some issue which may have had some unintended consequences.

@dlech dlech changed the title CI Builds with multiple new commits are uploading artifacts using the oldest commit instead of the newest commit CI Builds have incorrect version number reported Jul 3, 2023
@dlech
Copy link
Member

dlech commented Jul 3, 2023 •
edited
Loading

Actually, on second thought, this is probably related to MicroPython 1.20 changes on how we override the version macros.

I assume non-master branch builds show the correct version?

@laurensvalk
Copy link
Member Author

I assume non-master branch builds show the correct version?

I have only tried the nightly (master) links.

dlech added a commit to pybricks/pybricks-micropython that referenced this issue Jul 3, 2023
@dlech
github: fix MICROPY_GIT_* on master branch builds
1752bec 
Since updating to MicroPython v1.20, we now use environment variables
to override MICROPY_GIT_TAG and MICROPY_GIT_HASH. This was done in
the build-each-commit.py script but missed for master branch builds
since the script is not used in that case.

Issue: pybricks/support#1136
@dlech
Copy link
Member

dlech commented Jul 3, 2023

Fixed by pybricks/pybricks-micropython@1752bec and further improved by pybricks/pybricks-micropython@920bd471.

@dlech dlech closed this as completed Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
devops Issues related to continuous integration and distribution of software.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dlech @laurensvalk