pybricks/util_pb/pb_task: Don't wait for cancel on shutdown. #129
Conversation
laurensvalk
added
topic: bluetooth
|
For reproduction, use the script in pybricks/support#567 |
pybricks/util_pb/pb_task.c
Outdated
| @@ -41,7 +42,7 @@ void pb_wait_task(pbio_task_t *task, mp_int_t timeout) { | |||
| } else { | |||
| pbio_task_cancel(task); | |||
|
|
|||
| while (task->status == PBIO_ERROR_AGAIN) { | |||
| while (task->status == PBIO_ERROR_AGAIN && !pbsys_status_test(PBIO_PYBRICKS_STATUS_SHUTDOWN_REQUEST)) { | |||
There was a problem hiding this comment.
We should add a HACK comment here that explains that this is dangerous but is hopefully OK on shutdown. I'm a little concerned about USB hubs though since they don't actually power off on shutdown when the battery is charging, so this could cause hard crashes on those hubs. To avoid that, we would also need to empty any task queues so that we don't try to keep running zombie tasks.
There was a problem hiding this comment.
This hack is only needed on technic / city hub right now, so documenting it as a hack and enabling it only on non-charging hubs could work for now.
There was a problem hiding this comment.
I'm not against merging BT fixes by the way, we could talk about it tomorrow.
laurensvalk
force-pushed
the
pb-task-shutdown
branch
from
153d76e to
a7d4e8b
Compare
Fixes pybricks/support#814 so the user can at least turn the hub off without removing the batteries.
laurensvalk
force-pushed
the
pb-task-shutdown
branch
from
a7d4e8b to
01c5c73
Compare
Fixes pybricks/support#814. This also works around things like pybricks/support#567 so the user can at least turn the hub off without removing the batteries.