pbsys/light: Use pattern for connected idle state.

The connected idle state (blue) was a special case that acted as a default.

The default is now to have no light at all, so we can distinguish BLE connected from disconnected, and potentially distinguish from USB connected if we choose different patterns.

lib/pbio/include/pbio/protocol.h

@@ -323,6 +323,12 @@ typedef enum {
      * @since Pybricks Profile v1.2.0
      */
     PBIO_PYBRICKS_STATUS_SHUTDOWN_REQUEST = 8,
+    /**
+     * Hub is connected to a host (like Pybricks Code) via BLE.
+     *
+     * @since Pybricks Profile v1.4.0
+     */
+    PBIO_PYBRICKS_STATUS_BLE_HOST_CONNECTED = 9,
     /** Total number of indications. */
     NUM_PBIO_PYBRICKS_STATUS,
 } pbio_pybricks_status_t;

lib/pbio/sys/bluetooth.c

@@ -340,8 +340,11 @@ PROCESS_THREAD(pbsys_bluetooth_process, ev, data) {
         // If connected, advertising stops automatically. Otherwise manually
         // stop advertising (if the user code started using the button or we
         // are shutting down or or BLE became disabled).
-        if (!pbdrv_bluetooth_is_connected(PBDRV_BLUETOOTH_CONNECTION_LE)) {
+        if (pbdrv_bluetooth_is_connected(PBDRV_BLUETOOTH_CONNECTION_LE)) {
+            pbsys_status_set(PBIO_PYBRICKS_STATUS_BLE_HOST_CONNECTED);
+        } else {
             pbdrv_bluetooth_stop_advertising();
+            pbsys_status_clear(PBIO_PYBRICKS_STATUS_BLE_HOST_CONNECTED); // REVISIT: also via state...
         }
 
         // In all cases, clear the advertising flag to stop blinking.
@@ -388,6 +391,8 @@ PROCESS_THREAD(pbsys_bluetooth_process, ev, data) {
             PROCESS_WAIT_EVENT();
         }
 
+        pbsys_status_clear(PBIO_PYBRICKS_STATUS_BLE_HOST_CONNECTED);
+
         reset_all();
         PROCESS_WAIT_WHILE(pbsys_status_test(PBIO_PYBRICKS_STATUS_USER_PROGRAM_RUNNING));
 

lib/pbio/sys/light.c

@@ -29,6 +29,8 @@ typedef enum {
     PBSYS_STATUS_LIGHT_INDICATION_BLE_ADVERTISING_AND_LOW_VOLTAGE,
     PBSYS_STATUS_LIGHT_INDICATION_BLE_LOW_SIGNAL,
     PBSYS_STATUS_LIGHT_INDICATION_BLE_LOW_SIGNAL_AND_LOW_VOLTAGE,
+    PBSYS_STATUS_LIGHT_INDICATION_BLE_CONNECTED_IDLE,
+    PBSYS_STATUS_LIGHT_INDICATION_BLE_CONNECTED_IDLE_AND_LOW_VOLTAGE,
     PBSYS_STATUS_LIGHT_INDICATION_SHUTDOWN_REQUESTED,
     PBSYS_STATUS_LIGHT_INDICATION_SHUTDOWN,
 } pbsys_status_light_indication_t;
@@ -116,6 +118,20 @@ pbsys_status_light_indication_pattern[] = {
         { .color = PBIO_COLOR_WHITE, .duration = 1 },
         PBSYS_STATUS_LIGHT_INDICATION_PATTERN_REPEAT
     },
+    [PBSYS_STATUS_LIGHT_INDICATION_BLE_CONNECTED_IDLE] =
+        (const pbsys_status_light_indication_pattern_element_t[]) {
+        PBSYS_STATUS_LIGHT_INDICATION_PATTERN_FOREVER(PBIO_COLOR_BLUE),
+    },
+    [PBSYS_STATUS_LIGHT_INDICATION_BLE_CONNECTED_IDLE_AND_LOW_VOLTAGE] =
+        (const pbsys_status_light_indication_pattern_element_t[]) {
+        { .color = PBIO_COLOR_ORANGE, .duration = 6 },
+        { .color = PBIO_COLOR_BLUE, .duration = 8 },
+        { .color = PBIO_COLOR_ORANGE, .duration = 6 },
+        { .color = PBIO_COLOR_BLUE, .duration = 4 },
+        { .color = PBIO_COLOR_NONE, .duration = 16 },
+        { .color = PBIO_COLOR_BLUE, .duration = 4 },
+        PBSYS_STATUS_LIGHT_INDICATION_PATTERN_REPEAT
+    },
     [PBSYS_STATUS_LIGHT_INDICATION_SHUTDOWN_REQUESTED] =
         (const pbsys_status_light_indication_pattern_element_t[]) {
         { .color = PBIO_COLOR_BLACK, .duration = 1 },
@@ -179,6 +195,8 @@ void pbsys_status_light_init(void) {
 static void pbsys_status_light_handle_status_change(void) {
     pbsys_status_light_pattern_state_t *state = &pbsys_status_light_instance.pattern_state;
     pbsys_status_light_indication_t new_indication = PBSYS_STATUS_LIGHT_INDICATION_NONE;
+    bool ble_connected_idle = pbsys_status_test(PBIO_PYBRICKS_STATUS_BLE_HOST_CONNECTED) &&
+        !pbsys_status_test(PBIO_PYBRICKS_STATUS_USER_PROGRAM_RUNNING);
     bool ble_advertising = pbsys_status_test(PBIO_PYBRICKS_STATUS_BLE_ADVERTISING);
     bool ble_low_signal = pbsys_status_test(PBIO_PYBRICKS_STATUS_BLE_LOW_SIGNAL);
     bool low_voltage = pbsys_status_test(PBIO_PYBRICKS_STATUS_BATTERY_LOW_VOLTAGE_WARNING);
@@ -201,6 +219,10 @@ static void pbsys_status_light_handle_status_change(void) {
         new_indication = PBSYS_STATUS_LIGHT_INDICATION_BLE_LOW_SIGNAL_AND_LOW_VOLTAGE;
     } else if (ble_low_signal) {
         new_indication = PBSYS_STATUS_LIGHT_INDICATION_BLE_LOW_SIGNAL;
+    } else if (ble_connected_idle && low_voltage) {
+        new_indication = PBSYS_STATUS_LIGHT_INDICATION_BLE_CONNECTED_IDLE_AND_LOW_VOLTAGE;
+    } else if (ble_connected_idle) {
+        new_indication = PBSYS_STATUS_LIGHT_INDICATION_BLE_CONNECTED_IDLE;
     } else if (low_voltage) {
         new_indication = PBSYS_STATUS_LIGHT_INDICATION_LOW_VOLTAGE;
     }
@@ -358,10 +380,6 @@ void pbsys_status_light_poll(void) {
         if (instance->allow_user_update) {
             pbdrv_led_set_hsv(led, &instance->user_color);
         } else {
-            if (new_color == PBIO_COLOR_NONE) {
-                // System ID color
-                new_color = PBIO_COLOR_BLUE;
-            }
             pbio_color_hsv_t hsv;
             pbio_color_to_hsv(new_color, &hsv);
             pbdrv_led_set_hsv(led, &hsv);