Adds pre-commit #64
Merged
Adds pre-commit #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #64 +/- ##
===========================================
+ Coverage 86.88% 87.37% +0.49%
===========================================
Files 21 21
Lines 488 507 +19
===========================================
+ Hits 424 443 +19
Misses 64 64
|
martinjrobins
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
looks great, thanks @BradyPlanden. Looking forward to using ruff (at least in the background)
| - name: Check formatting with pre-commit | ||
| run: | | ||
| python -m pip install pre-commit | ||
| pre-commit run ruff |
There was a problem hiding this comment.
nice, ruff is the shiny new toy :)
.pre-commit-config.yaml
Outdated
| additional_dependencies: [ruff==0.0.284] | ||
| args: ["--fix","--ignore=E501,E402"] | ||
|
|
||
| # - repo: https://github.com/adamchainz/blacken-docs |
There was a problem hiding this comment.
do we need this or can be deleted?
There was a problem hiding this comment.
Agreed, I thought of leaving it for when we have the docs up and sorted, but we can just add it then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following (and closes #58):