Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

47-add-self-hosted-runner #62

Merged
merged 7 commits into from
Oct 26, 2023
Merged

Conversation

BradyPlanden
Copy link
Member

@BradyPlanden BradyPlanden commented Oct 23, 2023

This PR adds a daily triggered unit test to be completed on the self-hosted M2 mini as well as the GitHub-hosted runners.

Note, the workflow names have been updated to align with their tasks. The dependency installations have also been refactored as there was redundant code. Closes #47

@BradyPlanden BradyPlanden linked an issue Oct 23, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #62 (60d9a9e) into develop (30b72b1) will not change coverage.
The diff coverage is n/a.

❗ Current head 60d9a9e differs from pull request most recent head d240399. Consider uploading reports for the commit d240399 to get more accurate results

@@           Coverage Diff            @@
##           develop      #62   +/-   ##
========================================
  Coverage    79.15%   79.15%           
========================================
  Files           15       15           
  Lines          379      379           
========================================
  Hits           300      300           
  Misses          79       79           

@BradyPlanden
Copy link
Member Author

BradyPlanden commented Oct 23, 2023

This is now ready for review. A few items to note:

  • nlopt.py's support for Apple silicon hardware is quite poor. I've had to build from source onto the runner, which is required for each python version we wish to test. This is quite combersome, and is not a pleasant workflow for macOS users. I'll open an issue to discuss this problem moving forward. Edit: [Bug]: Nlopt install error for Apple silicon #63 is now open.
  • At the moment, I've limited the runner to python 3.10. Once we sort out the above issue, this should be reverted to the original python matrix (as completed here)

@BradyPlanden BradyPlanden force-pushed the 47-add-self-hosted-runner branch from 5feb7bd to d240399 Compare October 23, 2023 12:41
Copy link
Contributor

@martinjrobins martinjrobins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks great, thanks @BradyPlanden

@BradyPlanden BradyPlanden merged commit b19f280 into develop Oct 26, 2023
14 checks passed
@BradyPlanden BradyPlanden deleted the 47-add-self-hosted-runner branch October 26, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add self-hosted runner
2 participants