Restructure for improved modularity #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 16, 2023
Codecov Report
@@ Coverage Diff @@
## develop #60 +/- ##
===========================================
+ Coverage 79.15% 81.16% +2.01%
===========================================
Files 15 18 +3
Lines 379 531 +152
===========================================
+ Hits 300 431 +131
- Misses 79 100 +21
|
Closed
.gitattributes
Outdated
| @@ -301,3 +301,6 @@ $RECYCLE.BIN/ | |||
| *.lnk | |||
|
|
|||
| # End of https://www.toptal.com/developers/gitignore/api/python,macos,windows,linux,c | |||
|
|
|||
| # Visual Studio Code settings | |||
| .vscode/* | |||
| @@ -1,13 +1,13 @@ | |||
| # | |||
| # Root of the pybop module. | |||
| # Root of the PyBOP module. | |||
There was a problem hiding this comment.
We need to sort out a standard for this, real low priority though.
| # Provides access to all shared functionality (models, solvers, etc.). | ||
| # | ||
| # This file is adapted from Pints | ||
| # (see https://github.com/pints-team/pints) | ||
| # | ||
|
|
||
| import sys | ||
| import os | ||
| from os import path |
There was a problem hiding this comment.
Maybe don't need to change, depends on whether we need any functionality from os in the future.
| from .plotting.quick_plot import QuickPlot | ||
|
|
||
| # | ||
| # Remove any imported modules, so we don't expose them as part of PyBOP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request to address issue #54