Set minimising for each cost and make a property of BaseOptimiser only

[NicolaCourtier]

Description

To prevent against future hard-to-find errors in maximising (rather than) minimising cost functions, set the minimising option for each cost and make it a property of BaseOptimiser only. Save the (transformed) search parameters in the log alongside the model parameters.

Issue reference

Fixes #561

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

• Updated the CHANGELOG.md in reverse chronological order (newest at the top) with a concise description of the changes, including the PR number.
• Noted any breaking changes, including details on how it might impact existing functionality.

Type of change

• New Feature: A non-breaking change that adds new functionality.
• Optimization: A code change that improves performance.
• Examples: A change to existing or additional examples.
• Bug Fix: A non-breaking change that addresses an issue.
• Documentation: Updates to documentation or new documentation for new features.
• Refactoring: Non-functional changes that improve the codebase.
• Style: Non-functional changes related to code style (formatting, naming, etc).
• Testing: Additional tests to improve coverage or confirm functionality.
• Other: (Insert description of change)

Key checklist:

• No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
• All unit tests pass: $ nox -s tests
• The documentation builds: $ nox -s doctest

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

• Code is well-commented, especially in complex or unclear areas.
• Added tests that prove my fix is effective or that my feature works.
• Checked that coverage remains or improves, and added tests if necessary to maintain or increase coverage.

Thank you for contributing to our project! Your efforts help us to deliver great software.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.22%. Comparing base (c8b00e6) to head (9f08982).
Report is 42 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #588      +/-   ##
===========================================
+ Coverage    99.08%   99.22%   +0.14%     
===========================================
  Files           52       58       +6     
  Lines         3605     4267     +662     
===========================================
+ Hits          3572     4234     +662     
  Misses          33       33              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[BradyPlanden]

Thanks @NicolaCourtier - this is looking good, a few suggestions. I think it's an improvement over what we have at the moment :)

[BradyPlanden]

Looks good, thanks @NicolaCourtier! Two small suggestions.