-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
random_search optimiser added in the pints framework #580
Conversation
3dc64bf
to
2d5c7d2
Compare
42cb8cc
to
54bf352
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #580 +/- ##
===========================================
+ Coverage 99.08% 99.20% +0.11%
===========================================
Files 52 60 +8
Lines 3605 4376 +771
===========================================
+ Hits 3572 4341 +769
- Misses 33 35 +2 ☔ View full report in Codecov by Sentry. |
…0-add-a-random-sample-optimiser
…om/pybop-team/PyBOP into 440-add-a-random-sample-optimiser
240e1ad
to
f2842bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good @Dibyendu-IITKGP! A few comments and suggestions to align this class with the others.
Can you also add a changelog entry :) |
0224762
to
896139f
Compare
…m/pybop-team/PyBOP into 440-add-a-random-sample-optimiser
…m/pybop-team/PyBOP into 440-add-a-random-sample-optimiser
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Three small changes to the unit test addition, then I think we are good 🎉
@all-contributors |
I've put up a pull request to add @Dibyendu-IITKGP! 🎉 |
@all-contributors please add @Dibyendu-IITKGP for code. |
I've updated the pull request to add @Dibyendu-IITKGP! 🎉 |
Description
Add a simplistic random search optimiser, with the following API:
optim = pybop.RandomSearch( cost, max_iterations=1000, max_unchanged_iterations=100, population_size=50)
Issue reference
Fixes #440
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks: