Fix bug with old PyBaMM version being fetched for scheduled tests #572
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a small PR that fixes a sorting bug I noticed in the scheduled tests where the current iteration of them is being run against PyBaMM 24.9, even though PyBaMM 24.11.2 is now released and up on PyPI. The problem was that
jq
orders the releases by comparing the string's characters from left to right, and hence it does not understand the semantics of versioning schemas that we do, i.e., that 24.11 comes after 24.9 as far as software versions are concerned. Thesort
interprets them like numbers.Before this PR:
24.9.0
After sorting:
24.11.2
Issue reference
N/A
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.