Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with old PyBaMM version being fetched for scheduled tests #572

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

agriyakhetarpal
Copy link
Member

Description

This is a small PR that fixes a sorting bug I noticed in the scheduled tests where the current iteration of them is being run against PyBaMM 24.9, even though PyBaMM 24.11.2 is now released and up on PyPI. The problem was that jq orders the releases by comparing the string's characters from left to right, and hence it does not understand the semantics of versioning schemas that we do, i.e., that 24.11 comes after 24.9 as far as software versions are concerned. The sort interprets them like numbers.

Before this PR: 24.9.0
After sorting: 24.11.2

Issue reference

N/A

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

  • Updated the CHANGELOG.md in reverse chronological order (newest at the top) with a concise description of the changes, including the PR number.
  • Noted any breaking changes, including details on how it might impact existing functionality.

Type of change

  • New Feature: A non-breaking change that adds new functionality.
  • Optimization: A code change that improves performance.
  • Examples: A change to existing or additional examples.
  • Bug Fix: A non-breaking change that addresses an issue.
  • Documentation: Updates to documentation or new documentation for new features.
  • Refactoring: Non-functional changes that improve the codebase.
  • Style: Non-functional changes related to code style (formatting, naming, etc).
  • Testing: Additional tests to improve coverage or confirm functionality.
  • Other: (Insert description of change)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All unit tests pass: $ nox -s tests
  • The documentation builds: $ nox -s doctest

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is well-commented, especially in complex or unclear areas.
  • Added tests that prove my fix is effective or that my feature works.
  • Checked that coverage remains or improves, and added tests if necessary to maintain or increase coverage.

Thank you for contributing to our project! Your efforts help us to deliver great software.

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.15%. Comparing base (c8b00e6) to head (2e9f5b8).
Report is 24 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #572      +/-   ##
===========================================
+ Coverage    99.08%   99.15%   +0.06%     
===========================================
  Files           52       56       +4     
  Lines         3605     3903     +298     
===========================================
+ Hits          3572     3870     +298     
  Misses          33       33              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@BradyPlanden BradyPlanden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks @agriyakhetarpal!

@BradyPlanden BradyPlanden merged commit 84782f8 into pybop-team:develop Dec 2, 2024
31 checks passed
@agriyakhetarpal agriyakhetarpal deleted the patch-1 branch December 2, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants