Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled tests, lychee, default bounds #562

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

BradyPlanden
Copy link
Member

@BradyPlanden BradyPlanden commented Nov 20, 2024

Description

This PR does the following:

  • Loosens rhat assertions
  • Updates default bound application
  • Re-enables acceptance of 403 from lychee default

Issue reference

Fixes #556

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

  • Updated the CHANGELOG.md in reverse chronological order (newest at the top) with a concise description of the changes, including the PR number.
  • Noted any breaking changes, including details on how it might impact existing functionality.

Type of change

  • New Feature: A non-breaking change that adds new functionality.
  • Optimization: A code change that improves performance.
  • Examples: A change to existing or additional examples.
  • Bug Fix: A non-breaking change that addresses an issue.
  • Documentation: Updates to documentation or new documentation for new features.
  • Refactoring: Non-functional changes that improve the codebase.
  • Style: Non-functional changes related to code style (formatting, naming, etc).
  • Testing: Additional tests to improve coverage or confirm functionality.
  • Other: (Insert description of change)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All unit tests pass: $ nox -s tests
  • The documentation builds: $ nox -s doctest

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is well-commented, especially in complex or unclear areas.
  • Added tests that prove my fix is effective or that my feature works.
  • Checked that coverage remains or improves, and added tests if necessary to maintain or increase coverage.

Thank you for contributing to our project! Your efforts help us to deliver great software.

@BradyPlanden BradyPlanden linked an issue Nov 20, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.14%. Comparing base (c8b00e6) to head (539d5c0).
Report is 18 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #562      +/-   ##
===========================================
+ Coverage    99.08%   99.14%   +0.05%     
===========================================
  Files           52       55       +3     
  Lines         3605     3848     +243     
===========================================
+ Hits          3572     3815     +243     
  Misses          33       33              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@BradyPlanden BradyPlanden force-pushed the 556-bug-scheduled-tests-failing-on-rhat branch 2 times, most recently from d4844fc to 95bbf26 Compare November 20, 2024 14:11
@BradyPlanden BradyPlanden added the show This PR will be merged without review label Nov 20, 2024
@BradyPlanden BradyPlanden force-pushed the 556-bug-scheduled-tests-failing-on-rhat branch from 95bbf26 to 2d6dd2e Compare November 20, 2024 15:58
@BradyPlanden
Copy link
Member Author

Scheduled tests are still failing, see most recent run: https://github.com/pybop-team/PyBOP/actions/runs/11938283633; however, this is not due to the rhat assertion. We will need to take a look at the AdamW setup for the next round of integration test improvement steps.

@BradyPlanden BradyPlanden merged commit b2873c9 into develop Nov 20, 2024
31 checks passed
@BradyPlanden BradyPlanden deleted the 556-bug-scheduled-tests-failing-on-rhat branch November 21, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
show This PR will be merged without review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Scheduled tests failing on rhat
1 participant