-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor optimisation args #551
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al args, aligns maxiter and popsize to standardised name
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #551 +/- ##
===========================================
+ Coverage 99.08% 99.14% +0.05%
===========================================
Files 52 55 +3
Lines 3605 3848 +243
===========================================
+ Hits 3572 3815 +243
Misses 33 33 ☔ View full report in Codecov by Sentry. |
Marked as 'show', but would appreciate your input @NicolaCourtier. |
BradyPlanden
added a commit
that referenced
this pull request
Nov 15, 2024
BradyPlanden
added a commit
that referenced
this pull request
Nov 15, 2024
BradyPlanden
added a commit
that referenced
this pull request
Nov 25, 2024
* refactor: moves common Pints' optimisation keys from kwargs to optional args, aligns maxiter and popsize to standardised name * fix: benchmarks, coverage fix: benchmarks * fix: attribute selection in Optimisation class * adds changelog entry
BradyPlanden
added a commit
that referenced
this pull request
Nov 25, 2024
BradyPlanden
added a commit
that referenced
this pull request
Dec 4, 2024
* refactor: moves common Pints' optimisation keys from kwargs to optional args, aligns maxiter and popsize to standardised name * fix: benchmarks, coverage fix: benchmarks * fix: attribute selection in Optimisation class * adds changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
kwargs
to optional args for improved autocomplete and IDE highlightingmax_iterations
andpopulation_size
to default args across optimisers, withmaxiter
andpopsize
only available on SciPy based optimisersBasePintsOptimiser.pints_optimiser
renamed toBasePintsOptimiser.optimiser
Issue reference
Fixes # (issue-number)
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.