-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for numpy 2 compatibility #372
Conversation
The Pints's optimisers |
We can merge this PR ahead of the Pints's updates. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #372 +/- ##
===========================================
+ Coverage 97.29% 97.47% +0.18%
===========================================
Files 46 42 -4
Lines 2805 2418 -387
===========================================
- Hits 2729 2357 -372
+ Misses 76 61 -15 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the changes @NicolaCourtier.
PINTS is fixed now! |
Description
Updates are required to use Numpy 2.0. As for Pints (see their PR 1531), we just need to replace
np.array(x, copy=False)
withnp.asarray(x)
.Issue reference
Fixes #367.
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.