-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hessian check for 2-parameter problems #363
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #363 +/- ##
===========================================
+ Coverage 99.08% 99.19% +0.10%
===========================================
Files 52 59 +7
Lines 3605 4333 +728
===========================================
+ Hits 3572 4298 +726
- Misses 33 35 +2 ☔ View full report in Codecov by Sentry. |
I think we should continue with the slightly low coverage (98%) - the Hessian check is missing a test on the case where the optimal point is a saddle point for which we would need a relevant optimisation problem (this relates to #391). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @NicolaCourtier, a few suggestions/comments
Co-authored-by: Brady Planden <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just one suggestion.
Description
Add a
classify_using_Hessian
function that can assess the identifiability of an optimisation result and return an informative message to the user.Issue reference
Fixes #362.
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.