Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure optimisers to enable passing of kwargs #255

Merged
merged 95 commits into from
May 22, 2024

Rename _optimisation to base_optimiser

6b37c3f
Select commit
Loading
Failed to load commit list.
Merged

Restructure optimisers to enable passing of kwargs #255

Rename _optimisation to base_optimiser
6b37c3f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded May 22, 2024 in 0s

98.31% of diff hit (target 95.81%)

View this Pull Request on Codecov

98.31% of diff hit (target 95.81%)

Annotations

Check warning on line 158 in pybop/optimisers/base_optimiser.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

pybop/optimisers/base_optimiser.py#L158 

Added line #L158 was not covered by tests

Check warning on line 200 in pybop/optimisers/base_optimiser.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

pybop/optimisers/base_optimiser.py#L200 

Added line #L200 was not covered by tests

Check warning on line 188 in pybop/optimisers/scipy_optimisers.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

pybop/optimisers/scipy_optimisers.py#L188 

Added line #L188 was not covered by tests

Check warning on line 192 in pybop/optimisers/scipy_optimisers.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

pybop/optimisers/scipy_optimisers.py#L190-L192 

Added lines #L190 - L192 were not covered by tests
View more details on Codecov