-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check to CMAES and make XNES default optimiser #253
Conversation
I'm open to discussion on which optimiser to set as default, but the restriction on CMAES to multiple parameter optimisation problems only seems to rule it out from being the most user-friendly option! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #253 +/- ##
===========================================
- Coverage 95.33% 95.14% -0.20%
===========================================
Files 36 36
Lines 1971 1996 +25
===========================================
+ Hits 1879 1899 +20
- Misses 92 97 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the addition @NicolaCourtier. I agree, CMAES is probably not the most robust default. In the future, we may want differing defaults dependant on the dimensionality of the problem.
I took a quick look at the benchmarks and XNES appears to be the fastest pints optimiser for the two parameter problem, so another checkmark moving forward.
I've added a small tweak to be more explicit in the ValueError, happy to merge either way.
Co-authored-by: Brady Planden <[email protected]>
Description
Only CMAES appears to be restricted to optimising multiple parameters at a time. This suggests that we should change the default optimiser away from CMAES.
Issue reference
Fixes #91.
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s docs
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.