-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]: Add asv benchmarking #207
[WIP]: Add asv benchmarking #207
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #207 +/- ##
========================================
Coverage 94.29% 94.29%
========================================
Files 33 33
Lines 1753 1753
========================================
Hits 1653 1653
Misses 100 100 ☔ View full report in Codecov by Sentry. |
This should be ready for a review now. Since it adds a new workflow, I can't manually trigger until the workflow is added to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was fast, thanks @BradyPlanden! The benchmark suite looks great, I have a number of suggestions – but besides them, I would also suggest setting a fixed random seed, similar to what PyBaMM does:
import numpy as np
def set_random_seed(seed_value=42): # or anything you like
np.random.seed(seed_value)
in the ParameterisationBenchmark.setup()
method in parameterisation_benchmark.py
, or in a benchmark_util.py
shim file; as you like it.
Co-authored-by: Agriya Khetarpal <[email protected]>
…ove unused pandas dependancy
Now the benchmarks are proceeding to run, nice! |
Co-authored-by: Agriya Khetarpal <[email protected]>
…ement default_max_unchanged_iterations for more stable default
This PR does the following:
Closes #179.