-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PyBaMM IDAKLU Solver #176
Add PyBaMM IDAKLU Solver #176
Conversation
…update-basemodelsimulate-for-idaklu-output_variables
The IDAKLU solver does support native Windows and the compilation outputs a |
PSA: PyBaMM's IDAKLU solver is broken on Windows currently for 24.1 and might work with earlier versions, see pybamm-team/PyBaMM#3783 and pybamm-team/PyBaMM#3100. The Linux and macOS wheels do not have this issue (edit: they do too) |
For now, a suitable way to help unblock this PR could be to build PyBaMM from source by checking out from a particular tag on the PyBaMM repository (if testing a particular PyBaMM version is needed, say, v24.1). On Windows, it can take up to 15 mins to compile, but Linux and macOS (both x86_64 and M-series for the latter) are pretty fast and it should add about ~2 mins to the jobs for the entire compilation. Now that #204 is complete, it won't take to run the tests either and the CI time should stay below 10 minutes, though the Windows jobs would take around ~20mins (but will still fail though as far as I am aware due to a single |
Of course, we are working to cut a 24.1post1 patch release come out to fix this, not sure when that can be |
Hi @agriyakhetarpal, agreed, let's proceed with building from source to unblock this PR. If you can integrate that into the CI, that would be great. Once v24.1post1 is released, we can switch back to the wheels as you mentioned.
Shall we aim for linux and macOS for the time being? Thanks again for looking into this! |
That should work, we can skip the Windows build. I can write a PR to this branch where I can add PyBaMM to be compiled from source from the |
How do you feel about not using |
…lver-from-source Add PyBaMM IDAKLU solver, compiled from source
Closes #160. WIP investigating implementation and performance.