Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to v23.12 #155

Merged
merged 4 commits into from
Dec 19, 2023
Merged

Bump to v23.12 #155

merged 4 commits into from
Dec 19, 2023

Conversation

BradyPlanden
Copy link
Member

Closes #122.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (3ba9a6a) 93.03% compared to head (c0eb5a6) 93.41%.
Report is 11 commits behind head on develop.

Files Patch % Lines
pybop/_problem.py 93.10% 2 Missing ⚠️
pybop/optimisers/nlopt_optimize.py 66.66% 1 Missing ⚠️
pybop/optimisers/scipy_optimisers.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #155      +/-   ##
===========================================
+ Coverage    93.03%   93.41%   +0.37%     
===========================================
  Files           34       34              
  Lines         1178     1199      +21     
===========================================
+ Hits          1096     1120      +24     
+ Misses          82       79       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BradyPlanden
Copy link
Member Author

BradyPlanden commented Dec 19, 2023

The workflow changes seem to have enabled a full deployment to PyPI, so v23.12 was published from this branch. While this isn't what I was wanting, I think it's OK since we were happy with the state of this release. @martinjrobins any idea why this workflow proceeded through the PyPI job? I thought the !contains() would have resulted in a skip of PyPI, but the completion of the TestPyPI.

Edit: I see the issue, when I manually triggered the workflow for that commit, it uses the workflow associated from that commit. I think this is solved for future releases with the updated triggers and job logic.

Copy link
Contributor

@martinjrobins martinjrobins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@BradyPlanden BradyPlanden merged commit c07dd1a into develop Dec 19, 2023
46 of 49 checks passed
@BradyPlanden BradyPlanden deleted the v23.12 branch December 20, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release v23.12
2 participants