Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Population size setter broken for Pints' Optimisers #581

Closed
BradyPlanden opened this issue Dec 5, 2024 · 0 comments · Fixed by #582
Closed

[Bug]: Population size setter broken for Pints' Optimisers #581

BradyPlanden opened this issue Dec 5, 2024 · 0 comments · Fixed by #582
Assignees
Labels
bug Something isn't working

Comments

@BradyPlanden
Copy link
Member

Python Version

3.12

Describe the bug

Passing the population_size arg to Pints' based optimisers doesn't modify the optimiser population size

Steps to reproduce the behaviour

Test on any pints population based optimiser

Relevant log output

No response

@BradyPlanden BradyPlanden added the bug Something isn't working label Dec 5, 2024
@BradyPlanden BradyPlanden self-assigned this Dec 5, 2024
@BradyPlanden BradyPlanden linked a pull request Dec 5, 2024 that will close this issue
15 tasks
BradyPlanden added a commit that referenced this issue Dec 6, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* fix: population setter added, updates parameters.rvs() to be correctly shaped for population samplers

* refactor setter, update test import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant