update heuristic parameter convergence plot, add tex preprint format.

pybop-team · Nov 28, 2024 · d60e763 · d60e763
1 parent b1390e0
commit d60e763
Show file tree

Hide file tree

Showing 17 changed files with 894 additions and 8 deletions.
diff --git a/joss/figures/contour_heuristic_0.png b/joss/figures/contour_heuristic_0.png
diff --git a/joss/figures/contour_heuristic_1.png b/joss/figures/contour_heuristic_1.png
diff --git a/joss/figures/contour_heuristic_2.png b/joss/figures/contour_heuristic_2.png
diff --git a/joss/figures/heuristic_parameters.png b/joss/figures/heuristic_parameters.png
diff --git a/joss/figures/joss/contour_evolution.png b/joss/figures/joss/contour_evolution.png
diff --git a/joss/figures/joss/contour_gradient.png b/joss/figures/joss/contour_gradient.png
diff --git a/joss/figures/joss/contour_heuristic.png b/joss/figures/joss/contour_heuristic.png
diff --git a/joss/figures/joss/contour_total.png b/joss/figures/joss/contour_total.png
diff --git a/joss/figures/joss/converge.png b/joss/figures/joss/converge.png
diff --git a/joss/figures/joss/design.png b/joss/figures/joss/design.png
diff --git a/joss/figures/joss/optimisers_parameters.png b/joss/figures/joss/optimisers_parameters.png
diff --git a/joss/figures/joss/sim-landscape.png b/joss/figures/joss/sim-landscape.png
diff --git a/joss/paper.md b/joss/paper.md
@@ -1,7 +1,7 @@
 ---
 title: 'PyBOP: A Python package for battery model optimisation and parameterisation'
 tags:
-  - Python
+  - python
   - batteries
   - battery models
   - parameterisation
@@ -192,7 +192,7 @@ As an example, we consider the problem of maximising the gravimetric energy dens
 
 We gratefully acknowledge all [contributors](https://github.com/pybop-team/PyBOP?tab=readme-ov-file#contributors-) to this package. This work was supported by the Faraday Institution Multiscale Modelling (MSM) project (ref. FIRG059), UKRI's Horizon Europe Guarantee (ref. 10038031), and EU IntelLiGent project (ref. 101069765).
 
-[//]: # (# Discussion Points)
+[//]: # (# Open Discussion Points)
 
 [//]: # (EIS numerical identification)
 

diff --git a/joss/paper.pdf b/joss/paper.pdf
diff --git a/joss/paper.preprint.pdf b/joss/paper.preprint.pdf
diff --git a/joss/paper.preprint.tex b/joss/paper.preprint.tex
diff --git a/joss/param_plots.py b/joss/param_plots.py
@@ -18,9 +18,9 @@
 create_plot["landscape"] = False
 create_plot["minimising"] = False
 create_plot["maximising"] = False
-create_plot["gradient"] = True
+create_plot["gradient"] = False
 create_plot["evolution"] = False
-create_plot["heuristic"] = False
+create_plot["heuristic"] = True
 create_plot["posteriors"] = False
 
 
@@ -441,10 +441,10 @@
         optim = optimiser(
             cost,
             verbose=True,
-            sigma0=0.02,
-            max_iterations=500,
-            max_unchanged_iterations=25,
-            max_evaluations=300,
+            sigma0=0.05,
+            max_iterations=150,
+            max_unchanged_iterations=150,
+            max_evaluations=150,
             **kwargs,
         )
 
@@ -474,6 +474,7 @@
     parameter_fig.data = []
     parameter_fig.add_traces(parameter_traces)
     parameter_fig = plotly.subplots.make_subplots(figure=parameter_fig, rows=2, cols=1)
+    parameter_fig.update_layout(yaxis1=dict(range=[1e-14, 10e-14]))
     parameter_fig.show()
     parameter_fig.write_image("joss/figures/heuristic_parameters.png")