Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes 23.9 #63

Merged
merged 9 commits into from
Nov 20, 2023
Merged

Release notes 23.9 #63

merged 9 commits into from
Nov 20, 2023

Conversation

brosaplanella
Copy link
Member

@brosaplanella brosaplanella commented Oct 5, 2023

Entry to the news file for the Release Notes of PyBaMM 23.9.

(Work in progress)

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for pybamm-developer-preview ready!

Name Link
🔨 Latest commit db39a6e
🔍 Latest deploy log https://app.netlify.com/sites/pybamm-developer-preview/deploys/65563d784efd9d0007aa6ba6
😎 Deploy Preview https://deploy-preview-63--pybamm-developer-preview.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance:
Accessibility:
Best Practices:
SEO:
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@brosaplanella
Copy link
Member Author

@agriyakhetarpal is there an easy way to include a TOC just for that entry? I want to reproduce what they have here: https://julialang.org/blog/2023/04/julia-1.9-highlights/

@agriyakhetarpal
Copy link
Member

In that case it would be better to switch to multi-page news again. Is it fine if I can push changes to your branch here?

@brosaplanella
Copy link
Member Author

Whatever you think will work better in the long run. Not having a TOC is not a big deal, and we can always change things to multiple files later.

@agriyakhetarpal
Copy link
Member

I think keeping a single news file is better because of ease of access. I have just pushed a small change to the theme to include an optional table of contents in a file using the YAML frontmatter, does that work for you? To add it just for the latest news segment, we would need to switch to multiple news files, but I think this is clean enough

@brosaplanella
Copy link
Member Author

The release notes are now ready, let me know what you think. For this release, I prioritised having a somewhat simpler release notes to make the release sooner, as we are already quite behind schedule. For future releases, we can have a working branch so we can add to the notes as we add important features.

Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brosaplanella!

content/news.md Outdated Show resolved Hide resolved
Co-authored-by: Saransh Chopra <[email protected]>
content/news.md Outdated Show resolved Hide resolved
@brosaplanella
Copy link
Member Author

Just updated the notes so anytree is listed as a core dependency. @agriyakhetarpal how does the deployment work? If we merge this does the website update (almost) instantaneously? If so, @Saransh-cpp feel free to merge once you make the final release.

@agriyakhetarpal
Copy link
Member

Yes, the website will get updated almost instantaneously. Feel free to merge as soon as the release is out!

@brosaplanella brosaplanella merged commit d8f4775 into main Nov 20, 2023
3 of 4 checks passed
@brosaplanella brosaplanella deleted the release-notes-23.9 branch November 20, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants