Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jellyroll GSOC project #251

Merged
merged 4 commits into from
Feb 25, 2025
Merged

Conversation

rtimms
Copy link
Collaborator

@rtimms rtimms commented Feb 20, 2025

No description provided.

Copy link

netlify bot commented Feb 20, 2025

Deploy Preview for pybamm-developer-preview ready!

Name Link
🔨 Latest commit f42b7ad
🔍 Latest deploy log https://app.netlify.com/sites/pybamm-developer-preview/deploys/67bd963c75a135000875528d
😎 Deploy Preview https://deploy-preview-251--pybamm-developer-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 91
Accessibility: 100
Best Practices: 92
SEO: 92
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

arjxn-py
arjxn-py previously approved these changes Feb 25, 2025
Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @rtimms :)

Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't know if this was ready for review – I was thinking you would merge it on your own, @rtimms. :)

This looks good to me, with whichever of @arjxn-py's comments addressed as necessary.

@rtimms rtimms dismissed stale reviews from agriyakhetarpal and arjxn-py via f42b7ad February 25, 2025 10:06
@rtimms
Copy link
Collaborator Author

rtimms commented Feb 25, 2025

@agriyakhetarpal I don't have permissions :(

thanks for the comments @arjxn-py !

this is ready to merge

@agriyakhetarpal
Copy link
Member

I added you to the repo with "admin" permissions, thanks for letting me know!

@agriyakhetarpal agriyakhetarpal merged commit e581afe into pybamm-team:main Feb 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants