Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes for next release #214

Merged
merged 12 commits into from
Nov 22, 2024
Merged

Release notes for next release #214

merged 12 commits into from
Nov 22, 2024

Conversation

agriyakhetarpal
Copy link
Member

@agriyakhetarpal agriyakhetarpal commented Nov 3, 2024

Copy link

netlify bot commented Nov 3, 2024

Deploy Preview for pybamm-developer-preview ready!

Name Link
🔨 Latest commit 1408e80
🔍 Latest deploy log https://app.netlify.com/sites/pybamm-developer-preview/deploys/673f5d53760c640008eb812f
😎 Deploy Preview https://deploy-preview-214--pybamm-developer-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

valentinsulzer
valentinsulzer previously approved these changes Nov 12, 2024
@brosaplanella
Copy link
Member

I believe it would be good to have the telemetry info elsewhere, in addition to the release notes (I suggest under "About us"). Let me know what you think and I will open a PR @valentinsulzer @agriyakhetarpal. This way we can release that as soon as the release comes out, and then we can edit the release notes without rushing.

@agriyakhetarpal
Copy link
Member Author

I believe it would be good to have the telemetry info elsewhere, in addition to the release notes (I suggest under "About us"). Let me know what you think and I will open a PR

Sounds good to me, thanks, @brosaplanella!

@brosaplanella brosaplanella marked this pull request as ready for review November 21, 2024 15:12
brosaplanella
brosaplanella previously approved these changes Nov 21, 2024
Copy link
Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that Agriya opened the PR and he can't review it (but I have made significant changes) I am approving this. @agriyakhetarpal if you are happy with it just add a comment, but I think it would be good for @valentinsulzer to check as well.

We should hold merging it until the release is published.

Copy link
Member Author

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments, and we should be good to merge since the release is now out. Edit: and after Valentin approves the changes.

content/news/2024/11/21/pybamm-24.11.md Outdated Show resolved Hide resolved
content/news/2024/11/21/pybamm-24.11.md Outdated Show resolved Hide resolved
content/news/2024/11/21/pybamm-24.11.md Outdated Show resolved Hide resolved
content/news/2024/11/21/pybamm-24.11.md Outdated Show resolved Hide resolved
@brosaplanella
Copy link
Member

I want to make a LinkedIn post about the release so merging this now and we can always edit them afterwards.

@brosaplanella brosaplanella merged commit d9c584c into main Nov 22, 2024
5 of 6 checks passed
@brosaplanella brosaplanella deleted the next-release-notes branch November 22, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants