-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release notes for next release #214
Conversation
agriyakhetarpal
commented
Nov 3, 2024
•
edited
Loading
edited
- Telemetry collection in Add telemetry PyBaMM#4441
- Solver improvements
✅ Deploy Preview for pybamm-developer-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: Valentin Sulzer <[email protected]>
I believe it would be good to have the telemetry info elsewhere, in addition to the release notes (I suggest under "About us"). Let me know what you think and I will open a PR @valentinsulzer @agriyakhetarpal. This way we can release that as soon as the release comes out, and then we can edit the release notes without rushing. |
Sounds good to me, thanks, @brosaplanella! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that Agriya opened the PR and he can't review it (but I have made significant changes) I am approving this. @agriyakhetarpal if you are happy with it just add a comment, but I think it would be good for @valentinsulzer to check as well.
We should hold merging it until the release is published.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor comments, and we should be good to merge since the release is now out. Edit: and after Valentin approves the changes.
Co-authored-by: Agriya Khetarpal <[email protected]>
Co-authored-by: Agriya Khetarpal <[email protected]>
Co-authored-by: Agriya Khetarpal <[email protected]>
Co-authored-by: Agriya Khetarpal <[email protected]>
I want to make a LinkedIn post about the release so merging this now and we can always edit them afterwards. |