Fix issue 258 #259
Merged
Fix issue 258 #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #259 +/- ##
========================================
Coverage 94.78% 94.78%
========================================
Files 11 11
Lines 1188 1188
========================================
Hits 1126 1126
Misses 62 62 |
srikanthallu
approved these changes
May 26, 2023
|
@srikanthallu are you referring to documenting the plan to merge solving into PyBaMM or this specific bug fix. I normally update the changelog before merging develop into main but is probably good practice to update it on each PR if that's what you mean. |
|
Yes @TomTranter , I was referring to updating the changelog in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.