Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to hatch + modern python packaging #182

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Migrate to hatch + modern python packaging #182

merged 1 commit into from
Sep 1, 2022

Conversation

Saransh-cpp
Copy link
Member

I tested this locally, and both pip and conda builds work without any errors! To be on the safer side, could someone please test it out locally with pip and with conda (@wigging)?

@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #182 (f36a314) into develop (85769f2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #182   +/-   ##
========================================
  Coverage    96.65%   96.65%           
========================================
  Files           11       11           
  Lines         1197     1197           
========================================
  Hits          1157     1157           
  Misses          40       40           

@wigging
Copy link
Collaborator

wigging commented Aug 13, 2022

@Saransh-cpp I can try to install this with conda and will let you know if I have any issues. Also, what is hatch?

@Saransh-cpp
Copy link
Member Author

hatch is a modern build backend that handles packaging and building stuff for a python library. Most of the Python projects right now use setuptools which was the original replacement for the broken distutils backend, but the development of hatch is picking up more speed than the development of setuptools in terms of meeting the new PEPs. For instance, the editable install without a setup.py file was just introduced in setuptools, whereas it already exists in hatch - see https://peps.python.org/pep-0660/) -

(took more than a year to be introduced in the main setuptools repository) -

image

This will not affect the frontend or the user-facing functionalities in any way, but now hatch would be handling the packaging stuff of liionpack instead of setuptools.

@wigging
Copy link
Collaborator

wigging commented Aug 15, 2022

I created a conda environment using the hatch branch and ran the basic_16p2s.py example and everything works fine.

@wigging
Copy link
Collaborator

wigging commented Aug 15, 2022

Regarding modern approaches to packaging in Python. Using a src directory is the preferred approach these days.

@TomTranter
Copy link
Collaborator

Hi @Saransh-cpp looks good thanks for this. I tested conda install locally too

@TomTranter TomTranter merged commit d5b819f into develop Sep 1, 2022
@TomTranter TomTranter deleted the hatch branch September 1, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants