Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#981 fix casadi solver documentation #982

Merged
merged 1 commit into from
May 4, 2020
Merged

Conversation

martinjrobins
Copy link
Contributor

Description

Fixes #981

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • Bug fix (non-breaking change which fixes an issue)

@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #982 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #982   +/-   ##
========================================
  Coverage    97.50%   97.50%           
========================================
  Files          225      225           
  Lines        11831    11831           
========================================
  Hits         11536    11536           
  Misses         295      295           
Impacted Files Coverage Δ
pybamm/solvers/casadi_solver.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bdbdaf...c2a4fcc. Read the comment docs.

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinjrobins martinjrobins merged commit 1ef73a8 into develop May 4, 2020
@martinjrobins martinjrobins deleted the issue-981-doc-casadi branch May 4, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

documentation not correct for casadi solver - unused parameter method
2 participants