Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#977 make casadi solver default #978

Merged
merged 2 commits into from
May 1, 2020
Merged

#977 make casadi solver default #978

merged 2 commits into from
May 1, 2020

Conversation

rtimms
Copy link
Contributor

@rtimms rtimms commented May 1, 2020

Description

Makes CasadiSolver the default for DAE models

Fixes #977

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #978 into develop will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #978      +/-   ##
===========================================
- Coverage    97.48%   97.47%   -0.01%     
===========================================
  Files          222      222              
  Lines        11791    11785       -6     
===========================================
- Hits         11494    11488       -6     
  Misses         297      297              
Impacted Files Coverage Δ
...l_battery_models/lead_acid/base_lead_acid_model.py 100.00% <ø> (ø)
pybamm/models/base_model.py 98.78% <100.00%> (-0.01%) ⬇️
...ollector/effective_resistance_current_collector.py 96.29% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83fba98...55f5d60. Read the comment docs.

@rtimms rtimms merged commit 4e888cd into develop May 1, 2020
@rtimms rtimms deleted the issue-977-default-casadi branch May 1, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default Solver Casadi
2 participants