Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#936 remove some inputs #942

Merged
merged 6 commits into from
Apr 6, 2020
Merged

Conversation

valentinsulzer
Copy link
Member

@valentinsulzer valentinsulzer commented Apr 5, 2020

Description

Remove inputs like T_inf, E_r, R_g to function parameters.
I didn't put in any deprecation warnings, but don't think we need to start doing this yet.
Also please check I didn't make any mistakes in transcribing parameter values :)

Fixes #936

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Apr 5, 2020

Codecov Report

Merging #942 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #942   +/-   ##
========================================
  Coverage    98.09%   98.09%           
========================================
  Files          221      222    +1     
  Lines        11166    11175    +9     
========================================
+ Hits         10953    10962    +9     
  Misses         213      213           
Impacted Files Coverage Δ
...phite_Ecker2015/graphite_ocp_Ecker2015_function.py 100.00% <ø> (ø)
...L_Mohtat2020/graphite_entropic_change_PeymanMPM.py 100.00% <ø> (ø)
..._Marquis2019/graphite_entropic_change_Moura2016.py 100.00% <ø> (ø)
...s/LiNiCoO2_Ecker2015/nco_ocp_Ecker2015_function.py 100.00% <ø> (ø)
...C_UMBL_Mohtat2020/NMC_entropic_change_PeymanMPM.py 100.00% <ø> (ø)
.../cathodes/NMC_UMBL_Mohtat2020/NMC_ocp_PeymanMPM.py 100.00% <ø> (ø)
...co2_Marquis2019/lico2_entropic_change_Moura2016.py 100.00% <ø> (ø)
...thodes/lico2_Marquis2019/lico2_ocp_Dualfoil1998.py 100.00% <ø> (ø)
...9/electrolyte_conductivity_Landesfeind2019_base.py 100.00% <ø> (ø)
...19/electrolyte_diffusivity_Landesfeind2019_base.py 100.00% <ø> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aa4e20...d6943ec. Read the comment docs.

Copy link
Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in graphite_LGM50_electrolyte_reaction_rate_Chen2020. Apart from that, just 3 minor comments.

@valentinsulzer
Copy link
Member Author

Thanks Ferran, knew I would miss something 😅

Copy link
Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks Tino :)

@valentinsulzer valentinsulzer merged commit 07bfa3e into develop Apr 6, 2020
@valentinsulzer valentinsulzer deleted the issue-936-function-inputs branch April 6, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove inputs to function parameters
2 participants