-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#936 remove some inputs #942
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in graphite_LGM50_electrolyte_reaction_rate_Chen2020
. Apart from that, just 3 minor comments.
...rs/lithium-ion/anodes/graphite_Chen2020/graphite_LGM50_electrolyte_reaction_rate_Chen2020.py
Outdated
Show resolved
Hide resolved
pybamm/input/parameters/lithium-ion/electrolytes/LiPF6_Mohtat2020/parameters.csv
Outdated
Show resolved
Hide resolved
pybamm/input/parameters/lithium-ion/anodes/graphite_Ecker2015/parameters.csv
Outdated
Show resolved
Hide resolved
...input/parameters/lithium-ion/anodes/graphite_Chen2020/graphite_LGM50_diffusivity_Chen2020.py
Outdated
Show resolved
Hide resolved
Thanks Ferran, knew I would miss something 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks Tino :)
Description
Remove inputs like T_inf, E_r, R_g to function parameters.
I didn't put in any deprecation warnings, but don't think we need to start doing this yet.
Also please check I didn't make any mistakes in transcribing parameter values :)
Fixes #936
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: