Basic lead acid model #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #932 +/- ##
===========================================
+ Coverage 98.09% 98.14% +0.05%
===========================================
Files 222 223 +1
Lines 11176 11594 +418
===========================================
+ Hits 10963 11379 +416
- Misses 213 215 +2
Continue to review full report at Codecov.
|
valentinsulzer
requested review from
rtimms,
brosaplanella,
Scottmar93 and
TomTranter
brosaplanella
approved these changes
Apr 7, 2020
|
|
||
| References | ||
| ---------- | ||
| .. [2] V Sulzer, SJ Chapman, CP Please, DA Howey, and CW Monroe. Faster lead-acid |
There was a problem hiding this comment.
Minor typo: should the reference be [1]?
There was a problem hiding this comment.
It has to be a different number because "full" and "basicfull" are in the same doc file and sphinx doesn't like it if the same ref number is used twice
| @@ -6,7 +6,7 @@ | |||
|
|
|||
|
|
|||
| class Full(BaseModel): | |||
| """Porous electrode model for lead-acid, from [1]_, based on the Full | |||
| """Porous electrode model for lead-acid, from [1]_, based on the Newman-Tiedemann | |||
There was a problem hiding this comment.
Minor typo: should the underscore be removed?
There was a problem hiding this comment.
this is for sphinx cross-ref
TomTranter
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add basic lead-acid model (with convection)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: