Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 846 bugs #876

Merged
merged 22 commits into from
Mar 10, 2020
Merged

Issue 846 bugs #876

merged 22 commits into from
Mar 10, 2020

Conversation

valentinsulzer
Copy link
Member

Description

Fix miscellaneous bugs for implementing fuel cell models

Fixes #846
Fixes #742
Fixes #735

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@valentinsulzer valentinsulzer changed the base branch from develop to master March 9, 2020 22:03
@valentinsulzer valentinsulzer changed the base branch from master to develop March 9, 2020 22:03
@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #876 into develop will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #876      +/-   ##
===========================================
+ Coverage    97.76%   97.79%   +0.03%     
===========================================
  Files          210      210              
  Lines        10523    10585      +62     
===========================================
+ Hits         10288    10352      +64     
+ Misses         235      233       -2
Impacted Files Coverage Δ
pybamm/expression_tree/independent_variable.py 100% <ø> (ø) ⬆️
pybamm/expression_tree/functions.py 100% <ø> (ø) ⬆️
pybamm/expression_tree/exceptions.py 100% <ø> (ø) ⬆️
pybamm/expression_tree/symbol.py 96.99% <ø> (ø) ⬆️
pybamm/parameters/parameter_values.py 100% <100%> (ø) ⬆️
pybamm/solvers/casadi_algebraic_solver.py 100% <100%> (ø) ⬆️
pybamm/quick_plot.py 98.86% <100%> (ø) ⬆️
pybamm/expression_tree/unary_operators.py 96.56% <100%> (+0.41%) ⬆️
...mm/expression_tree/operations/convert_to_casadi.py 92.85% <100%> (+0.43%) ⬆️
pybamm/expression_tree/operations/evaluate.py 95.83% <100%> (+0.18%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 150f07f...b52353f. Read the comment docs.

Copy link
Contributor

@rtimms rtimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good thanks!

@valentinsulzer valentinsulzer merged commit eae19f2 into develop Mar 10, 2020
@valentinsulzer valentinsulzer deleted the issue-846-bugs branch March 10, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some annoying bugs from trying fuel cell models Derivative of abs node Minimum/Maximum
2 participants