-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 846 bugs #876
Issue 846 bugs #876
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #876 +/- ##
===========================================
+ Coverage 97.76% 97.79% +0.03%
===========================================
Files 210 210
Lines 10523 10585 +62
===========================================
+ Hits 10288 10352 +64
+ Misses 235 233 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good thanks!
Description
Fix miscellaneous bugs for implementing fuel cell models
Fixes #846
Fixes #742
Fixes #735
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: