-
-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 830 algebraic #868
Issue 830 algebraic #868
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #868 +/- ##
===========================================
+ Coverage 97.70% 97.75% +0.04%
===========================================
Files 201 202 +1
Lines 10433 10459 +26
===========================================
+ Hits 10194 10224 +30
+ Misses 239 235 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
# set it to 0 | ||
if self.algebraic_solver is True and t_eval is None: | ||
t_eval = np.array([0]) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we need to raise an error here if t_eval is None and the solver isn't algebraic?
Description
Reformat algebraic solver to be more in line with the other solvers, and add casadi algebraic solver.
We could call the algebraic solvers to initialize the dae models, would reduce code duplication, but might be a little bit confusing?
Fixes #830
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: