Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#863 remove double-count #864

Merged
merged 3 commits into from
Mar 4, 2020
Merged

#863 remove double-count #864

merged 3 commits into from
Mar 4, 2020

Conversation

valentinsulzer
Copy link
Member

Description

Remove double-counted number of electrodes in parallel

Fixes #863

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

Merging #864 into develop will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #864      +/-   ##
===========================================
- Coverage    97.71%   97.66%   -0.05%     
===========================================
  Files          209      207       -2     
  Lines        10731    10510     -221     
===========================================
- Hits         10486    10265     -221     
  Misses         245      245
Impacted Files Coverage Δ
...amm/models/submodels/current_collector/__init__.py 100% <ø> (ø) ⬆️
...bamm/models/submodels/thermal/x_lumped/__init__.py 100% <ø> (ø) ⬆️
...m/models/full_battery_models/base_battery_model.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1f4018...412fe37. Read the comment docs.

@valentinsulzer valentinsulzer merged commit bf5283c into develop Mar 4, 2020
@valentinsulzer valentinsulzer deleted the issue-863-double-count branch March 4, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double counting electrodes in parallel
2 participants